feat: add separate max token lifetime for administrators #18267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6214f1d to
4c418e6
Compare
johnstcn
approved these changes
Jun 6, 2025
There was a problem hiding this comment.
I'd like to see some tests for the inverse (shorter admin max token lifetime), as I could imagine security-conscious orgs wanting to minimize dangerous token lifetimes. There's also a potentially misleading comment. Apart from that, I don't need to review again.
4c418e6 to
9f15ef9
Compare
johnstcn
reviewed
Jun 6, 2025
Change-Id: I4540ce3eeb46ab58909ac37e60c3ece93668212a Signed-off-by: Thomas Kosiewski <tk@coder.com>
9f15ef9 to
a8ea1f9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add separate token lifetime limits for administrators
This PR introduces a new configuration option
--max-admin-token-lifetimethat allows administrators to create API tokens with longer lifetimes than regular users. By default, administrators can create tokens with a lifetime of up to 7 days (168 hours), while the existing--max-token-lifetimesetting continues to apply to regular users.The implementation:
MaximumAdminTokenDurationfield to the session configurationThis change allows organizations to grant administrators extended token lifetimes while maintaining tighter security controls for regular users.
Fixes #17395