Skip to content

chore: use spaces over tabs in proto files #18269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025
Merged

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Jun 6, 2025

No description provided.

@johnstcn
Copy link
Member

johnstcn commented Jun 6, 2025

If we're worried about indentation, the protobuf style guide says to use 2 spaces

@Emyrk
Copy link
Member Author

Emyrk commented Jun 6, 2025

If we're worried about indentation, the protobuf style guide says to use 2 spaces

Oof, I'm just making this file consistent. Given it's at 4 spaces right now, I assume most people's editors are doing that.

I'll let it be someone else's problem later to change it to 2 lol. This is just bothering me

Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to ignore the style guide, let's do it consistently!

@Emyrk Emyrk merged commit 348d19d into main Jun 6, 2025
36 checks passed
@Emyrk Emyrk deleted the stevenmasley/proto_use_spaces branch June 6, 2025 14:11
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants