chore: remove dynamic-parameters experiment #18290
Conversation
- Regenerated TypeScript types to remove dynamic-parameters experiment - Updated useDynamicParametersOptOut hook to always return optedOut: true since the experiment was removed - This fixes test failures related to dynamic parameters functionality Co-authored-by: jaaydenh <1858163+jaaydenh@users.noreply.github.com>
Fix for Test FailuresI've identified and fixed the test failures in this PR. The issues were: 1.
|
coderd/parameters_test.go
Outdated
| @@ -249,6 +249,7 @@ func TestDynamicParametersWithTerraformValues(t *testing.T) { | |||
| Value: "GO", | |||
| }, | |||
| } | |||
| request.EnableDynamicParameters = true | |||
There was a problem hiding this comment.
We should really set the template to dynamic params, because we are going to drop this field soon.
coderd/wsbuilder/wsbuilder.go
Outdated
| func (b *Builder) usingDynamicParameters() bool { | ||
| vals, err := b.getTemplateTerraformValues() | ||
| if b.dynamicParametersEnabled != nil { | ||
| return *b.dynamicParametersEnabled | ||
| } | ||
|
|
||
| tpl, err := b.getTemplate() | ||
| if err != nil { | ||
| return false // Let another part of the code get this error | ||
| } | ||
| if tpl.UseClassicParameterFlow { | ||
| return false | ||
| } | ||
|
|
||
| if !ProvisionerVersionSupportsDynamicParameters(vals.ProvisionerdVersion) { | ||
| vals, err := b.getTemplateTerraformValues() | ||
| if err != nil { | ||
| return false | ||
| } | ||
|
|
||
| if b.dynamicParametersEnabled != nil { | ||
| return *b.dynamicParametersEnabled | ||
| if !ProvisionerVersionSupportsDynamicParameters(vals.ProvisionerdVersion) { | ||
| return false | ||
| } | ||
|
|
||
| tpl, err := b.getTemplate() | ||
| if err != nil { | ||
| return false // Let another part of the code get this error | ||
| } | ||
| return !tpl.UseClassicParameterFlow | ||
| return true | ||
| } |
No description provided.