feat: add ai tasks migrations #18359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
101e894 to
2b15938
Compare
coderd/database/models.go
Outdated
| @@ -3355,6 +3355,7 @@ type TemplateVersion struct { | |||
| Message string `db:"message" json:"message"` | |||
| Archived bool `db:"archived" json:"archived"` | |||
| SourceExampleID sql.NullString `db:"source_example_id" json:"source_example_id"` | |||
| HasAiTask bool `db:"has_ai_task" json:"has_ai_task"` | |||
There was a problem hiding this comment.
Nit: can you use sqlc to correct the naming here to HasAITask?
2b15938 to
e4e2035
Compare
e4e2035 to
50f1008
Compare
There was a problem hiding this comment.
🚫 [linkspector] reported by reviewdog 🐶
Cannot reach https://splunk.com Status: null Navigation timeout of 30000 ms exceeded
coder/docs/admin/security/audit-logs.md
Line 83 in 50f1008
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds database migrations required for the Tasks feature.
There's a slight difference between the migrations in this PR and the RFC: this PR adds
NOT NULLconstraints to thehas_ai_taskcolumns. It was an oversight on my part when I wrote the RFC - I assumed theDEFAULT FALSEvalue would make the columns implicitly NOT NULL, but that's not the case with Postgres. We have no use for the NULL value.The
DEFAULT FALSEstatement ensures that the migration will pass even when there are existing rows in the template version and workspace builds tables, so there's no danger in adding theNOT NULLconstraints.