chore: use large modules in dogfood template #18389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large modules can potentially break or slow down template behaviors. Our primary dogfood template should experience this if it becomes an issue.
johnstcn
reviewed
Jun 16, 2025
Yes sir! I made a version that uses this module and created/deleted a workspace. |
johnstcn
approved these changes
Jun 16, 2025
matifali
reviewed
Jun 16, 2025
Comment on lines
+20
to
+22
| module "large-5mb-module" { | ||
| source = "git::https://github.com/Emyrk/large-module.git" | ||
| } |
There was a problem hiding this comment.
This could be used to test our Terraform module caching proxy.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large modules can potentially break or slow down template behaviors. Our primary dogfood template should experience this if it becomes an issue.
Just trying to catch things in dogfood before we experience them in the wild.
Note: On
maintoday, you would never know this used to be a problem. I see no difference, and want to keep it that way.