Skip to content

fix(agent/agentcontainers): reduce need to recreate sub agents #18402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Jun 17, 2025

Unless significant agent fields change, like directory, name, or apps, we no longer re-create the subagent. This reduces DB load and decreases the chance of hitting edge cases from deletion (although this will be addressed later).

Updates #18332

@mafredri mafredri requested review from johnstcn and DanielleMaywood and removed request for johnstcn June 17, 2025 10:57
@mafredri mafredri force-pushed the mafredri/fix-agentcontainers-avoid-unnecessary-subagent-recreation branch 2 times, most recently from bea0596 to 2391dae Compare June 17, 2025 12:39
@mafredri mafredri marked this pull request as ready for review June 17, 2025 12:40
@mafredri mafredri force-pushed the mafredri/fix-agentcontainers-avoid-unnecessary-subagent-recreation branch from 2391dae to 2ec5a58 Compare June 17, 2025 12:41
@mafredri mafredri force-pushed the mafredri/fix-agentcontainers-update-subagent-client branch from c033618 to 1b9e884 Compare June 17, 2025 13:46
@mafredri mafredri force-pushed the mafredri/fix-agentcontainers-avoid-unnecessary-subagent-recreation branch from d9b224a to 5fb9441 Compare June 17, 2025 13:48
Base automatically changed from mafredri/fix-agentcontainers-update-subagent-client to main June 17, 2025 13:58
@mafredri mafredri force-pushed the mafredri/fix-agentcontainers-avoid-unnecessary-subagent-recreation branch from 5fb9441 to b861e04 Compare June 17, 2025 14:16
@mafredri mafredri merged commit 7fa1ad8 into main Jun 17, 2025
37 checks passed
@mafredri mafredri deleted the mafredri/fix-agentcontainers-avoid-unnecessary-subagent-recreation branch June 17, 2025 15:53
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants