Skip to content

chore: update Go version to 1.24.4 #18408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

chore: update Go version to 1.24.4 #18408

merged 1 commit into from
Jun 17, 2025

Conversation

blink-so[bot]
Copy link
Contributor

@blink-so blink-so bot commented Jun 17, 2025

Updates all Go version references in the codebase to use Go 1.24.4.

Changes

  • Update go.mod to use Go 1.24.4
  • Update dogfood/coder/Dockerfile GO_VERSION to 1.24.4
  • Update .github/actions/setup-go/action.yaml default version to 1.24.4
  • Update examples/parameters-dynamic-options/variables.yml to use golang:1.24

Testing

  • ✅ All Go version references are consistent (verified with scripts/check_go_versions.sh)
  • ✅ Build tested successfully with Go 1.24.4
  • ✅ Binary runs correctly

@blink-so @sreya
Update Go version to 1.24.4
0004ab2 
- Update go.mod to use Go 1.24.4
- Update dogfood/coder/Dockerfile GO_VERSION to 1.24.4
- Update .github/actions/setup-go/action.yaml default version to 1.24.4
- Update examples/parameters-dynamic-options/variables.yml to use golang:1.24
- All Go version references are now consistent
- Build tested successfully with Go 1.24.4

Co-authored-by: sreya <4856196+sreya@users.noreply.github.com>
@sreya sreya changed the title Update Go version to 1.24.4 chore: update Go version to 1.24.4 Jun 17, 2025
@sreya sreya requested a review from deansheather June 17, 2025 15:39
deansheather
deansheather reviewed Jun 17, 2025
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to update flake.nix

examples/parameters-dynamic-options/variables.yml
@@ -1,2 +1,2 @@
go_image: "bitnami/golang:1.20-debian-11"
go_image: "bitnami/golang:1.24-debian-11"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@blink-so blink.so
Copy link
Contributor Author

blink-so bot commented Jun 17, 2025

@deansheather Could you clarify what specific change is needed in flake.nix?

Currently it's using unstablePkgs.go_1_24 which should be correct for Go 1.24.x versions, and the version check script is passing:

INFO : go.mod                   : 1.24.4
INFO : dogfood/coder/Dockerfile : 1.24.4  
INFO : setup-go/action.yaml     : 1.24.4
INFO : flake.nix                : 1.24
Go version check passed, all versions are 1.24.4

Should I update to a different Nix package or make a different change?

deansheather
deansheather approved these changes Jun 17, 2025
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess ur right, thanks bro

@deansheather
Copy link
Member

Go ahead and merge it, blink

@deansheather
Copy link
Member

nvm I guess you can't

@deansheather deansheather merged commit 1a69338 into main Jun 17, 2025
43 checks passed
@deansheather deansheather deleted the update-go-1.24.4 branch June 17, 2025 15:46
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deansheather