Skip to content

fix: set fileSize to full length instead of unread portion #18409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

fix: set fileSize to full length instead of unread portion #18409

merged 1 commit into from
Jun 17, 2025

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Jun 17, 2025

content.Len() would return 0 bytes after a file was fully read. Since the buffer Len function returns the length of the unread portion.

@Emyrk Emyrk requested a review from jaaydenh June 17, 2025 15:23
@Emyrk Emyrk changed the title fix: file_size should be full length, not unread portion fix: set fileSize to full length instead of unread portion Jun 17, 2025
@Emyrk Emyrk merged commit aee96c9 into main Jun 17, 2025
33 checks passed
@Emyrk Emyrk deleted the stevenmasley/cache_size branch June 17, 2025 15:57
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jaaydenh jaaydenh jaaydenh approved these changes

Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emyrk @jaaydenh