Skip to content

feat: add ephemeral parameter dialog for workspace start/restart #18413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 20, 2025
Merged

feat: add ephemeral parameter dialog for workspace start/restart #18413

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
99f7a2d
feat: add ephemeral parameter dialog for workspace start/restart
blink-so[bot] Jun 17, 2025
7f56518
fix: use asChild prop instead of as prop for Button components
blink-so[bot] Jun 17, 2025
abea8ec
fix: improvements to UX and flow
jaaydenh Jun 17, 2025
1ff6988
fix: format
jaaydenh Jun 17, 2025
c7e1fad
chore: update stories
jaaydenh Jun 17, 2025
6d69706
fix: remove index.ts
jaaydenh Jun 18, 2025
718350d
chore: cleanup html
jaaydenh Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: cleanup html
  • Loading branch information
@jaaydenh
jaaydenh committed Jun 18, 2025
commit 718350d84fc9d6677b4103ffc3b4ba0ff2cf4a1a
24 changes: 13 additions & 11 deletions site/src/components/EphemeralParametersDialog/EphemeralParametersDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,18 +52,20 @@ export const EphemeralParametersDialog: FC<EphemeralParametersDialogProps> = ({
ephemeral parameters that will be reset to their default values
</DialogDescription>
<DialogDescription>
{ephemeralParameters.map((param) => (
<div key={param.name}>
<p className="text-content-primary m-0 font-bold">
{param.display_name || param.name}
</p>
{param.description && (
<p className="m-0 text-sm text-content-secondary">
{param.description}
<ul className="list-none pl-6 space-y-2">
{ephemeralParameters.map((param) => (
<li key={param.name}>
<p className="text-content-primary m-0 font-bold">
{param.display_name || param.name}
</p>
)}
</div>
))}
{param.description && (
<p className="m-0 text-sm text-content-secondary">
{param.description}
</p>
)}
</li>
))}
</ul>
</DialogDescription>
<DialogDescription>
Would you like to go to the workspace parameters page to review and
Expand Down
28 changes: 15 additions & 13 deletions site/src/pages/WorkspacePage/WorkspaceActions/BuildParametersPopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,19 +122,21 @@ const BuildParametersPopoverContent: FC<BuildParametersPopoverContentProps> = ({
workspace parameters page
</p>

<div className="flex flex-col gap-2">
{ephemeralParameters.map((param) => (
<div key={param.name} className="flex flex-col gap-2">
<p className="text-content-primary m-0 font-bold">
{param.display_name || param.name}
</p>
{param.description && (
<div className="m-0 text-sm text-content-secondary">
{param.description}
</div>
)}
</div>
))}
<div>
<ul className="list-none pl-3 space-y-2">
{ephemeralParameters.map((param) => (
<li key={param.name}>
<p className="text-content-primary m-0 font-bold">
{param.display_name || param.name}
</p>
{param.description && (
<p className="m-0 text-sm text-content-secondary">
{param.description}
</p>
)}
</li>
))}
</ul>
</div>

<Button className="w-full" onClick={handleGoToParameters}>
Expand Down
Loading