feat: add idle app status #18415
feat: add idle app status #18415
Conversation
"Idle" is more accurate than "complete" since: 1. AgentAPI only knows if the screen is active; it has no way of knowing if the task is complete. 2. The LLM might be done with its current prompt, but that does not mean the task is complete either (it likely needs refinement). The "complete" state will be reserved for future definition.
4b4786a to
c649ea1
Compare
The status row looks janky with just the icon. We can get into a "no message" state if the LLM never reported a status update.
c649ea1 to
86cf445
Compare
| @@ -0,0 +1 @@ | |||
| -- It is not possible to delete enum values. | |||
There was a problem hiding this comment.
I don't think that's true. These steps should revert the enum to its original set of values:
- Replace any occurences of new enum values with different values
- Rename the enum to something else
- Re-create the original enum
- Update columns to use the new enum
- Drop the renamed enum
Here are the SQL statements you'd use: https://blink.so/chat/Revert-Enum-Value-in-Postgres-5vVDbfY5A7ZOLPxyuqVgsG
There was a problem hiding this comment.
Ah yeah I meant there is no ALTER DELETE to mirror ALTER ADD but yeah we could recreate the entire enum. But from what I saw this is how our other migrations handle enum downgrades.
I am not sure if that means it is a good idea, but it is consistent at least.
Although...I wonder if this causes issues with queries or any enum validation in the Go code. Maybe we need to add downgrades to all of these enums. 😢
It would also mean all the idle states would be incorrect (although maybe renaming to complete would not be too bad) which is unfortunate.
"Idle" is more accurate than "complete" since:
The "complete" state will be reserved for future definition.
Additionally, in the case where the screen goes idle but the LLM never reported a status update, we can get an idle icon without a message, and it looks kinda janky in the UI so if there is no message I display the state text.
Closes coder/internal#699