-
Notifications
You must be signed in to change notification settings - Fork 914
feat: add idle app status #18415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add idle app status #18415
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
-- It is not possible to delete enum values. | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
ALTER TYPE workspace_app_status_state ADD VALUE IF NOT EXISTS 'idle'; |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that's true. These steps should revert the enum to its original set of values:
Here are the SQL statements you'd use: https://blink.so/chat/Revert-Enum-Value-in-Postgres-5vVDbfY5A7ZOLPxyuqVgsG
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah I meant there is no
ALTER DELETE
to mirrorALTER ADD
but yeah we could recreate the entire enum. But from what I saw this is how our other migrations handle enum downgrades.I am not sure if that means it is a good idea, but it is consistent at least.
Although...I wonder if this causes issues with queries or any enum validation in the Go code. Maybe we need to add downgrades to all of these enums. 😢
It would also mean all the idle states would be incorrect (although maybe renaming to
complete
would not be too bad) which is unfortunate.