Skip to content

fix: defensively handle nil maps and slices in marshaling #18418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 17, 2025
Merged

fix: defensively handle nil maps and slices in marshaling #18418

merged 3 commits into from
Jun 17, 2025

Conversation

angrycub
Copy link
Contributor

Adds a custom marshaler to handle some cases where nils were being marshaled to nulls, causing the web UI to throw an error.

@angrycub angrycub requested a review from Emyrk June 17, 2025 20:54
@angrycub angrycub self-assigned this Jun 17, 2025
@angrycub angrycub added api Area: HTTP API s2 Broken use cases or features (with a workaround). Only humans may set this. enterprise Enterprise-license / premium functionality labels Jun 17, 2025
@angrycub angrycub merged commit 44d4646 into main Jun 17, 2025
34 checks passed
@angrycub angrycub deleted the cv-fix-bad-idp-flags-nil branch June 17, 2025 21:50
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Emyrk Emyrk Emyrk approved these changes

Assignees

@angrycub angrycub

Labels
api Area: HTTP API enterprise Enterprise-license / premium functionality s2 Broken use cases or features (with a workaround). Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@angrycub @Emyrk