Skip to content

chore: refactor dynamic parameters into dedicated package #18420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jun 20, 2025
Merged

chore: refactor dynamic parameters into dedicated package #18420

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
1ca9483
wip
Emyrk Jun 17, 2025
d4dab77
refactor and move dynamic param rendering
Emyrk Jun 17, 2025
c50ee08
fixup FileError test
Emyrk Jun 17, 2025
8152bb7
more wip
Emyrk Jun 17, 2025
247470e
chore: add dynamic parameter unit test
Emyrk Jun 18, 2025
6799896
add another dynamic param
Emyrk Jun 18, 2025
08bffe2
add some comments
Emyrk Jun 18, 2025
f651edc
fmt
Emyrk Jun 18, 2025
67644cc
remove need to constantly send owner id
Emyrk Jun 18, 2025
ea4aa7d
linting
Emyrk Jun 18, 2025
758cd26
refactor loader
Emyrk Jun 18, 2025
e8f1d2d
comments
Emyrk Jun 18, 2025
23840d9
linting
Emyrk Jun 18, 2025
6328899
add idea
Emyrk Jun 18, 2025
cd46813
merge in main
Emyrk Jun 18, 2025
21b24d2
spelling
Emyrk Jun 20, 2025
7a1622d
add comment, remove unused field
Emyrk Jun 20, 2025
db612b3
chore: reprot json error as param diagnostic
Emyrk Jun 20, 2025
000f722
minor fixes
Emyrk Jun 20, 2025
7b80138
only use 1 function, not a 2 step
Emyrk Jun 20, 2025
c1902a7
Revert "only use 1 function, not a 2 step"
Emyrk Jun 20, 2025
d2634e2
only use 1 function, not a 2 step
Emyrk Jun 20, 2025
21ce54b
refactor TemplateVersionParameter to be a converter func
Emyrk Jun 20, 2025
ae82770
Merge branch 'main' into stevenmasley/dynamic_param_pkg
Emyrk Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
spelling
  • Loading branch information
@Emyrk
Emyrk committed Jun 20, 2025
commit 21b24d2f1ce90fe87707490a9c9b715dff9fb596
2 changes: 1 addition & 1 deletion coderd/dynamicparameters/render.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ func (r *Loader) dynamicRenderer(ctx context.Context, db database.Store, cache *
close: func() {
// Up to 2 files are cached, and must be released when rendering is complete.
// TODO: Might be smart to always call release when the context is
// cancelled.
// canceled.
templateFS.Close()
if moduleFilesFS != nil {
moduleFilesFS.Close()
Expand Down
Loading