Skip to content

chore: improve logging and x11 handler call #18422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

chore: improve logging and x11 handler call #18422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions agent/agentssh/agentssh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ func (s *Server) sessionHandler(session ssh.Session) {

x11, hasX11 := session.X11()
if hasX11 {
display, handled := s.x11Handler(session.Context(), x11)
display, handled := s.x11Handler(ctx, x11)
if !handled {
logger.Error(ctx, "x11 handler failed")
closeCause("x11 handler failed")
Expand Down Expand Up @@ -973,7 +973,7 @@ func (s *Server) handleConn(l net.Listener, c net.Conn) {
return
}
defer s.trackConn(l, c, false)
logger.Info(context.Background(), "started serving connection")
logger.Info(context.Background(), "started serving ssh connection")
// note: srv.ConnectionCompleteCallback logs completion of the connection
s.srv.HandleConn(c)
}
Expand Down
Loading