fix!: stop workspace before update #18425
Draft
+393
−208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c33f9b9.
42420b1 to
fa2d4eb
Compare
aslilac
reviewed
Jun 18, 2025
| @@ -21,19 +20,39 @@ export interface ActionButtonProps { | |||
| tooltipText?: string; | |||
| } | |||
|
|
|||
| export const UpdateButton: FC<ActionButtonProps> = ({ | |||
| export const UpdateAndStartButton: FC<ActionButtonProps> = ({ | |||
There was a problem hiding this comment.
I would probably keep this as one component that takes a prop like isRunning or something to change the text, since that seems to be the main difference
| loading, | ||
| }) => { | ||
| return ( | ||
| <Tooltip title="Stop workspace, if running, and restart it with the latest template version."> |
There was a problem hiding this comment.
Suggested change
| <Tooltip title="Stop workspace, if running, and restart it with the latest template version."> | |
| <Tooltip title="Stop workspace and restart it with the latest template version."> |
more confident wording. unless I'm misunderstanding, that's the point of this change.
| export const UpdateAndStartButton: FC<ActionButtonProps> = ({ | ||
| handleAction, | ||
| }) => { | ||
| export const UpdateAndStartButtonRequireActiveVersion: FC< |
There was a problem hiding this comment.
similarly, this could also just be an activeVersionRequired prop, rather than exponentially increasing the number of Update(.+)Button(.+?) components we have
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17840
NOTE: calling this out as a breaking change so that it is highly visible in the changelog.
coder updateto stop the workspace if already running.