Skip to content

chore(agent): add workspace owner env var and log dev container app failures #18433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 19, 2025

Conversation

DanielleMaywood
Copy link
Contributor

@DanielleMaywood DanielleMaywood commented Jun 18, 2025

Listen to feedback that was missed in #18346

  • Adds CODER_WORKSPACE_OWNER_NAME into the agent environment.
  • Logs warnings for when dev container app creation fails.

@DanielleMaywood DanielleMaywood marked this pull request as ready for review June 18, 2025 16:05
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Just one small request, please update the PR title to match the changes. 😄

@DanielleMaywood DanielleMaywood changed the title chore(agent): feedback based on #18346 chore(agent): add workspace owner env var and log dev container app failures Jun 18, 2025
@DanielleMaywood DanielleMaywood merged commit 118bf98 into main Jun 19, 2025
34 checks passed
@DanielleMaywood DanielleMaywood deleted the dm-pr-feedback-oops branch June 19, 2025 08:37
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants