Skip to content

chore: clarify install options in README #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 27, 2022
Merged

chore: clarify install options in README #1844

merged 7 commits into from
May 27, 2022

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented May 27, 2022

Fixes #1810 and documents a quick way to add vars to PATH, inspired by the kubectx package

@bpmct bpmct requested review from khorne3 and jsjoeio May 27, 2022 15:25
@bpmct bpmct requested a review from f0ssel May 27, 2022 15:57
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bpmct and others added 5 commits May 27, 2022 12:53
Co-authored-by: Katie Horne <katie@coder.com>
Co-authored-by: Katie Horne <katie@coder.com>
Co-authored-by: Katie Horne <katie@coder.com>
Co-authored-by: Katie Horne <katie@coder.com>
Co-authored-by: Katie Horne <katie@coder.com>
@bpmct bpmct enabled auto-merge (squash) May 27, 2022 17:55
@bpmct bpmct merged commit bde3779 into main May 27, 2022
@bpmct bpmct deleted the bpmct/install-clarify branch May 27, 2022 18:10
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
* chore: clarify install options in README

* clarify the path is an example, not a requirement

* Update README.md

Co-authored-by: Katie Horne <katie@coder.com>

* Update README.md

Co-authored-by: Katie Horne <katie@coder.com>

* Update README.md

Co-authored-by: Katie Horne <katie@coder.com>

* Update README.md

Co-authored-by: Katie Horne <katie@coder.com>

* Update README.md

Co-authored-by: Katie Horne <katie@coder.com>

Co-authored-by: Katie Horne <katie@coder.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: expand system service usage in README
4 participants