Skip to content

feat(agent/agentcontainers): support agent name in customization #18451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 19, 2025
Merged

feat(agent/agentcontainers): support agent name in customization #18451

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a5278c9
feat(agent/agentcontainers): support agent name in customization
DanielleMaywood Jun 19, 2025
db59693
chore: add extra test case
DanielleMaywood Jun 19, 2025
d094205
chore: ignore invalid names
DanielleMaywood Jun 19, 2025
b738124
refactor: include configuration and merged configuration
DanielleMaywood Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add extra test case 
Technically this doesn't really test anything new but it is good to have
an explicit test for anyways.
  • Loading branch information
@DanielleMaywood
DanielleMaywood committed Jun 19, 2025
commit db59693f91ce55390665e30d8eff85447a05f238
11 changes: 11 additions & 0 deletions agent/agentcontainers/api_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1765,6 +1765,17 @@ func TestAPI(t *testing.T) {
require.NotEqual(t, "custom-name", subAgent.Name)
},
},
{
name: "EmptyNameIsIgnored",
customization: []agentcontainers.CoderCustomization{
{
Name: "",
},
},
afterCreate: func(t *testing.T, subAgent agentcontainers.SubAgent) {
require.NotEmpty(t, subAgent.Name)
},
},
}

for _, tt := range tests {
Expand Down
Loading