Skip to content

feat: RBAC scopes per API key (WIP) #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

feat: RBAC scopes per API key (WIP) #1846

wants to merge 2 commits into from

Conversation

dwahler
Copy link
Contributor

@dwahler dwahler commented May 27, 2022

This PR adds a scope field to the api_keys table, and checks operations against the key's scope as well as the user's roles.

This is currently a pretty hacky/minimal WIP, and mostly exists to test my assumptions about how to fit this change into the existing RBAC machinery. Only any and readonly scopes are currently implemented.

@Emyrk
Copy link
Member

Emyrk commented May 31, 2022

This is pretty much exactly what I had in mind. 👍

@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions bot added stale This issue is like stale bread. and removed stale This issue is like stale bread. labels Jul 23, 2022
@ammario ammario added the stale This issue is like stale bread. label Jul 24, 2022
@github-actions github-actions bot removed the stale This issue is like stale bread. label Jul 24, 2022
@github-actions
Copy link

github-actions bot commented Aug 1, 2022

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Aug 1, 2022
@Emyrk
Copy link
Member

Emyrk commented Aug 1, 2022

I don't think we need this right now. We should wait until there is a need

@dwahler
Copy link
Contributor Author

dwahler commented Aug 1, 2022

Yep, let's revisit this when it becomes a priority on the roadmap.

@dwahler dwahler closed this Aug 1, 2022
@deansheather deansheather reopened this Sep 14, 2022
@deansheather
Copy link
Member

With David's permission from Slack, I'm reopening this so I can use it for devurl permissions

@deansheather
Copy link
Member

Actually it's pretty heavily outdated and has loads of conflicts, I might just open a new PR instead and pull David's code in by hand

@deansheather deansheather mentioned this pull request Sep 14, 2022
Merged
1 task
@github-actions github-actions bot deleted the david/token-scopes branch February 4, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale This issue is like stale bread.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dwahler @Emyrk @deansheather @ammario