Skip to content

feat(agent/agentcontainers): fall back to workspace folder name #18466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 23, 2025
Merged

feat(agent/agentcontainers): fall back to workspace folder name #18466

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
398c460
feat(agent/agentcontainers): fall back to workspace folder name
DanielleMaywood Jun 20, 2025
32e7320
chore: appease linter and add test case
DanielleMaywood Jun 20, 2025
7704238
chore: grammar
DanielleMaywood Jun 20, 2025
e0ffe69
chore: move subAgentConfig.Directory assignment
DanielleMaywood Jun 20, 2025
a1a8957
chore: re-add removed
DanielleMaywood Jun 23, 2025
52875a4
chore: flip order
DanielleMaywood Jun 23, 2025
ad39074
chore: improve comment
DanielleMaywood Jun 23, 2025
0ea4b12
chore: filepath.Base -> filepath.ToSlash & path.Base
DanielleMaywood Jun 23, 2025
4fdb580
chore: replace empty check with AgentNameRegex check
DanielleMaywood Jun 23, 2025
d38339a
chore: truncate name if over 64 characters long
DanielleMaywood Jun 23, 2025
5647a48
chore: fix oops
DanielleMaywood Jun 23, 2025
ac8e241
test: scenario with very long name
DanielleMaywood Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: improve comment
  • Loading branch information
@DanielleMaywood
DanielleMaywood committed Jun 23, 2025
commit ad39074c5b56bdfe2b103747393a6769caec77b1
5 changes: 3 additions & 2 deletions agent/agentcontainers/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,8 +585,9 @@ func (api *API) processUpdatedContainersLocked(ctx context.Context, updated code
if !api.devcontainerNames[dc.Name] {
// If the devcontainer name wasn't set via terraform, we
// will attempt to create an agent name based on the workspace
// folder's name. If that is not possible, we will fall back
// to using the container's friendly name.
// folder's name. If it is not possible to generate a valid
// agent name based off of the folder name (i.e. no valid characters),
// we will instead fall back to using the container's friendly name.
dc.Name = safeAgentName(filepath.Base(dc.WorkspaceFolder), dc.Container.FriendlyName)
}
}
Expand Down