Skip to content

chore: assume template versions without tf values to be empty #18479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged

chore: assume template versions without tf values to be empty #18479

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eba1c36
chore: template versions without tf values assumed to be empty
Emyrk Jun 20, 2025
5eee729
fixup
Emyrk Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: template versions without tf values assumed to be empty
  • Loading branch information
@Emyrk
Emyrk committed Jun 20, 2025
commit eba1c36e7ca3ce30aaec4c469ec997cdf4d27c04
16 changes: 15 additions & 1 deletion coderd/dynamicparameters/render.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@

import (
"context"
"database/sql"
"io/fs"
"log/slog"
"sync"
"time"

"github.com/google/uuid"
"golang.org/x/sync/errgroup"
Expand Down Expand Up @@ -105,7 +107,19 @@

if r.terraformValues == nil {
values, err := db.GetTemplateVersionTerraformValues(ctx, r.templateVersion.ID)
if err != nil {
if xerrors.Is(err, sql.ErrNoRows) {

Check failure on line 110 in coderd/dynamicparameters/render.go

View workflow job for this annotation

GitHub Actions / lint 

early-return: if c { ... } else { ... return } can be simplified to if !c { ... return } ... (revive)
// If the row does not exist, return zero values.
//
// Older template versions (prior to dynamic parameters) will be missing
// this row, and we can assume the 'ProvisionerdVersion' "" (unknown).
values = database.TemplateVersionTerraformValue{
TemplateVersionID: r.templateVersionID,
UpdatedAt: time.Time{},
CachedPlan: nil,
CachedModuleFiles: uuid.NullUUID{},
ProvisionerdVersion: "",
}
} else {
return xerrors.Errorf("template version terraform values: %w", err)
}
r.terraformValues = &values
Expand Down
Loading