Skip to content

chore: update template opt-in checkbox #18481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2025
+28 −9
Merged

chore: update template opt-in checkbox #18481

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7aac8e
chore: update template opt-in checkbox
jaaydenh Jun 20, 2025
026fb44
fix: update docs link
jaaydenh Jun 20, 2025
2df36b4
fix: handle inverted check state
jaaydenh Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: handle inverted check state
  • Loading branch information
@jaaydenh
jaaydenh committed Jun 20, 2025
commit 2df36b448b7aab8896352be249bb850a0f825915
7 changes: 6 additions & 1 deletion site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,12 @@ export const TemplateSettingsForm: FC<TemplateSettingsForm> = ({
id="use_classic_parameter_flow"
name="use_classic_parameter_flow"
checked={!form.values.use_classic_parameter_flow}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the function that passes to the API to flip the value too? Like on the request?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, good catch, we do because someone decided to use an inverted state for this setting. fixed. =)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the onchange below

onChange={form.handleChange}
onChange={(event) =>
form.setFieldValue(
"use_classic_parameter_flow",
!event.currentTarget.checked,
)
}
disabled={false}
/>
}
Expand Down
Loading