fix(vpn): avoid setting session token header twice #18524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f53cc17 to
591a3b7
Compare
591a3b7 to
bafa0c6
Compare
bafa0c6 to
cbf7ec7
Compare
deansheather
approved these changes
Jun 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coderdcurrently does not handle a session token header value of the formtoken1, token2. However, it does handle multiple instances of the token header by simply taking the first. This is the default behaviour ofhttp.Header.Get.So, setting the token header twice causes issues when Coder is behind a proxy that merges duplicate headers, such as Apache.
This PR ensures we don't set it twice by not sharing one slice between the
HTTPClientand thewebsocket.DialerOptions. It also adds a regression test.