Skip to content

chore: improve visuals of dynamic parameters #18537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

chore: improve visuals of dynamic parameters #18537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ const ParameterLabel: FC<ParameterLabelProps> = ({
htmlFor={id}
className="flex gap-2 flex-wrap text-sm font-medium"
>
<span className="flex">
<span className="flex font-semibold">
{displayName}
{parameter.required && (
<span className="text-content-destructive">*</span>
Expand Down Expand Up @@ -175,7 +175,8 @@ const ParameterLabel: FC<ParameterLabelProps> = ({
</span>
</TooltipTrigger>
<TooltipContent className="max-w-xs">
This parameter only applies for a single workspace start
This parameter is ephemeral and will reset to the template
default on workspace restart.
</TooltipContent>
</Tooltip>
</TooltipProvider>
Expand Down Expand Up @@ -209,7 +210,7 @@ const ParameterLabel: FC<ParameterLabelProps> = ({
</span>
</TooltipTrigger>
<TooltipContent className="max-w-xs">
Autofilled from the URL
Autofilled from the URL.
</TooltipContent>
</Tooltip>
</TooltipProvider>
Expand Down
8 changes: 3 additions & 5 deletions site/src/pages/WorkspacePage/WorkspaceActions/BuildParametersPopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,10 @@ const BuildParametersPopoverContent: FC<BuildParametersPopoverContentProps> = ({

return (
<div className="flex flex-col gap-4 p-5">
<h1 className="text-xl m-0 text-content-primary font-semibold leading-none ">
Ephemeral Parameters
</h1>
<p className="m-0 text-sm text-content-secondary">
This template has ephemeral parameters that must be configured on the
workspace parameters page
This workspace has ephemeral parameters which may use a temporary
value on workspace start. Configure the following parameters in
workspace settings.
</p>

<div>
Expand Down
2 changes: 1 addition & 1 deletion ...WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPageViewExperimental.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ export const WorkspaceParametersPageViewExperimental: FC<
{(templateVersionId || workspace.latest_build.template_version_id) && (
<div className="flex flex-col gap-2">
<Label className="text-sm text-content-secondary">Version ID</Label>
<p className="m-0 text-sm font-medium">
<p className="m-0 text-xs font-medium font-mono">
{templateVersionId ?? workspace.latest_build.template_version_id}
</p>
</div>
Expand Down
Loading