refactor: remove beta label from 'select a preset' menu #18538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BrunoQuaresma could you also remove the same beta label from CreateWorkspacePageViewExperiemental for dynamic parameters? |
SasSwart
reviewed
Jun 25, 2025
| @@ -404,11 +404,6 @@ export const CreateWorkspacePageViewExperimental: FC< | |||
| </Tooltip> | |||
| </TooltipProvider> | |||
| </span> | |||
| <FeatureStageBadge | |||
There was a problem hiding this comment.
Should we be removing the badge for dynamic params as well? AFAIK that's still in beta for a bit longer.
There was a problem hiding this comment.
This badge should definitely stay here. I was expecting the beta badge next to the Preset label on the dynamic parameters create workspace badge would be removed.
There was a problem hiding this comment.
Ok, I will rollback the change and @jaaydenh feel free to remove the dynamic parameter badge in another PR
3e3a16b to
15ab057
Compare
jaaydenh
approved these changes
Jun 25, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.