Skip to content

fix: correct hasAITaskResources logic for child modules #18542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

fix: correct hasAITaskResources logic for child modules #18542

merged 1 commit into from
Jun 24, 2025

Conversation

hugodutka
Copy link
Contributor

@hugodutka hugodutka commented Jun 24, 2025 •
edited
Loading

As far as I can tell, a resource label in the terraform graph is its address.
Resource addresses are prefixed with module paths if they are in child modules. https://developer.hashicorp.com/terraform/internals/json-format#plan-representation

Here's a partial output of terraform graph -type=plan on a Coder template that defines a coder_ai_task inside a module that confirms this:

digraph {
        compound = "true"
        newrank = "true"
        subgraph "root" {
                "[root] coder_agent.dev (expand)" [label = "coder_agent.dev", shape = "box"]
                "[root] coder_app.preview (expand)" [label = "coder_app.preview", shape = "box"]
                "[root] coder_metadata.container_info (expand)" [label = "coder_metadata.container_info", shape = "box"]
                "[root] coder_metadata.home_volume (expand)" [label = "coder_metadata.home_volume", shape = "box"]
                "[root] docker_volume.home_volume (expand)" [label = "docker_volume.home_volume", shape = "box"]
                ...
                "[root] module.claude-code.coder_ai_task.claude_code (expand)" [label = "module.claude-code.coder_ai_task.claude_code", shape = "box"]
                "[root] module.claude-code.coder_app.claude_code (expand)" [label = "module.claude-code.coder_app.claude_code", shape = "box"]
                "[root] module.claude-code.coder_app.claude_code_web (expand)" [label = "module.claude-code.coder_app.claude_code_web", shape = "box"]
                ...
        }
}

follow up to #18449, related to #18453

@hugodutka hugodutka requested a review from johnstcn June 24, 2025 17:01
@hugodutka hugodutka marked this pull request as ready for review June 24, 2025 17:01
@hugodutka hugodutka requested a review from dannykopping June 24, 2025 17:01
dannykopping
dannykopping approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dannykopping dannykopping merged commit b6c493d into main Jun 24, 2025
46 checks passed
@dannykopping dannykopping deleted the hugodutka/has-ai-task-resources-fix branch June 24, 2025 17:14
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dannykopping dannykopping dannykopping approved these changes

@sreya sreya sreya approved these changes

@johnstcn johnstcn Awaiting requested review from johnstcn

Assignees

@hugodutka hugodutka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugodutka @dannykopping @sreya