Skip to content

chore(coderd/database): optimize AuditLogs queries #18600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 1, 2025
+763 −244
Merged

chore(coderd/database): optimize AuditLogs queries #18600

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
339f1de
Extract count from audit logs query to a separate one and optimize au…
kacpersaw Jun 25, 2025
dad1a28
Fix lint
kacpersaw Jun 26, 2025
0587a91
Fix CountAuthorizedAuditLogs query impl
kacpersaw Jun 26, 2025
ee0e49c
Add consistency check for audit logs SQL queries
kacpersaw Jun 26, 2025
b599e4d
Construct count filter in searchquery.AuditLogs method
kacpersaw Jun 30, 2025
1d8b0ac
Reformat auditlogs.sql
kacpersaw Jun 30, 2025
4e578a4
Fix lint
kacpersaw Jun 30, 2025
e82acd0
Regenerate queries, fix fmt
kacpersaw Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint
  • Loading branch information
@kacpersaw
kacpersaw committed Jun 26, 2025
commit dad1a28b447f539e0b2451450a53e86544063f7f
6 changes: 3 additions & 3 deletions coderd/database/querier_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2042,9 +2042,9 @@ func TestAuthorizedAuditLogs(t *testing.T) {
require.NoError(t, err)

// Then: All logs for both organizations are returned and count matches
expectedLogs := append(orgAuditLogs[first], orgAuditLogs[second]...)
expectedCount := int64(len(expectedLogs))
require.Equal(t, expectedCount, count, "count should match sum of both organizations")
expectedLogs := append([]uuid.UUID{}, orgAuditLogs[first]...)
expectedLogs = append(expectedLogs, orgAuditLogs[second]...)
require.Equal(t, int64(len(expectedLogs)), count, "count should match sum of both organizations")
require.ElementsMatch(t, expectedLogs, auditOnlyIDs(logs), "logs from both organizations should be returned")
})

Expand Down
Loading