Skip to content

fix(agent/agentcontainers): avoid logspam in API updaterLoop #18710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025
Merged

fix(agent/agentcontainers): avoid logspam in API updaterLoop #18710

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
706f7ce
fix(agent/agentcontainers): avoid logspam in API updaterLoop
mafredri Jul 2, 2025
ec4743e
appease linter...
mafredri Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
appease linter...
  • Loading branch information
@mafredri
mafredri committed Jul 2, 2025
commit ec4743e864d29aadccecba7fd5ed1c9ed2061ac8
10 changes: 5 additions & 5 deletions agent/agentcontainers/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,11 +467,11 @@ func (api *API) updaterLoop() {
if err != nil {
if errors.Is(err, context.Canceled) {
api.logger.Warn(api.ctx, "updater loop ticker canceled", slog.Error(err))
} else {
// Avoid excessive logging of the same error.
if prevErr == nil || prevErr.Error() != err.Error() {
api.logger.Error(api.ctx, "updater loop ticker failed", slog.Error(err))
}
return nil
}
// Avoid excessive logging of the same error.
if prevErr == nil || prevErr.Error() != err.Error() {
api.logger.Error(api.ctx, "updater loop ticker failed", slog.Error(err))
}
prevErr = err
} else {
Expand Down
Loading