Skip to content

test: add test that we close stdin on SSH session close #18711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Jul 2, 2025

closes #18519

Adds a unit test that verifies that we close the stdin to a non-TTY process when the SSH session connected to it exits.

c.f. #18519 (comment)

Validates that we match OpenSSH behavior.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@spikecurtis spikecurtis requested review from johnstcn and mafredri and removed request for johnstcn July 2, 2025 12:02
@spikecurtis spikecurtis marked this pull request as ready for review July 2, 2025 12:03
@spikecurtis spikecurtis force-pushed the spike/18519-test-close-stdin branch from 8f0098e to 9c14eb8 Compare July 2, 2025 12:04
@spikecurtis spikecurtis force-pushed the spike/18519-test-close-stdin branch from 9c14eb8 to 2184b16 Compare July 2, 2025 12:09
@spikecurtis spikecurtis merged commit 59c8b56 into main Jul 2, 2025
35 checks passed
Copy link
Contributor Author

Merge activity

@spikecurtis spikecurtis deleted the spike/18519-test-close-stdin branch July 2, 2025 12:23
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VS Code Desktop connection drops shortly after reconnecting
3 participants