Skip to content

test(agent/agentssh): use fish shell compatible exit status checking #18824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

test(agent/agentssh): use fish shell compatible exit status checking #18824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test(agent/agentssh): use fish shell compatible exit status checking
  • Loading branch information
@ethanndickson
ethanndickson committed Jul 10, 2025
commit 106af85f24181e341712d656cc511fa69c3b3f1e
2 changes: 1 addition & 1 deletion agent/agentssh/agentssh_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ func TestSSHServer_ClosesStdin(t *testing.T) {
// exit code 1 if it hits EOF, which is what we want to test.
cmdErrCh := make(chan error, 1)
go func() {
cmdErrCh <- sess.Start(fmt.Sprintf("echo started; read; echo \"read exit code: $?\" > %s", filePath))
cmdErrCh <- sess.Start(fmt.Sprintf(`echo started; echo "read exit code: $(read && echo 0 || echo 1)" > %s`, filePath))
}()

cmdErr := testutil.RequireReceive(ctx, t, cmdErrCh)
Expand Down
Loading