fix(agent/agentcontainers): fix TestAPI/IgnoreCustomization flake
#18863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestAPI/IgnoreCustomization flake
There was a problem hiding this comment.
Pull Request Overview
Fixes a flaky race condition in TestAPI by waiting for container refresh to complete before asserting subagent creation.
- Wrapped
api.RefreshContainerscalls inrequire.Eventuallyfto poll forfakeSAC.createdentries after filesystem events. - Applied the same change in both phases of the test to ensure subagent creation is detected reliably.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a flake spotted here https://github.com/coder/coder/actions/runs/16277283041/job/45959150449
The flake occurred due to a race condition between
RefreshContainersand the file system watcher. We might want to improve how these tests are written in the future, but for now it appears this change has fixed the flake on my Coder Workspace.How I ran the test to recreate the issue