Skip to content

fix(site): tighten interface design for various frontend utility functions #18894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Aug 14, 2025
Merged

fix(site): tighten interface design for various frontend utility functions #18894

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
bb05088
refactor: centralize storybook queries key
Parkreiner Jul 16, 2025
a119d70
refactor: centralize template version key prefix
Parkreiner Jul 16, 2025
5dc67cf
refactor: remove JSX extension from batch actions
Parkreiner Jul 16, 2025
4c77bff
fix: update API design of various utility hooks
Parkreiner Jul 16, 2025
4833ae1
fix: remove promise race conditions for batch utilities
Parkreiner Jul 16, 2025
b8d92fa
fix: decouple component props from one another
Parkreiner Jul 16, 2025
1662a55
fix: apply biome fixes
Parkreiner Jul 16, 2025
e326414
refactor: remove more bad coupling
Parkreiner Jul 16, 2025
cc00106
fix: format
Parkreiner Jul 16, 2025
7304644
fix: update call site mismatch
Parkreiner Jul 16, 2025
b512e18
fix: update import
Parkreiner Jul 16, 2025
cb92b79
fix: update Filter logic to account for fallback filter
Parkreiner Jul 16, 2025
86d19b8
docs: add comment about wonky code
Parkreiner Jul 16, 2025
330d91d
fix: get workspace tests passing
Parkreiner Jul 16, 2025
fb9d8f2
fix: update biome again
Parkreiner Jul 16, 2025
de02ad1
Merge branch 'main' into mes/batch-update-01
Parkreiner Aug 14, 2025
ebd8b1c
chore: apply feedback
Parkreiner Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: update call site mismatch
  • Loading branch information
@Parkreiner
Parkreiner committed Jul 16, 2025
commit 7304644f60413f673706f8f2f2021f8fe836f7cd
3 changes: 2 additions & 1 deletion site/src/pages/ConnectionLogPage/ConnectionLogPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ const ConnectionLogPage: FC = () => {
paginatedConnectionLogs(searchParams),
);
const filter = useFilter({
searchParamsResult: [searchParams, setSearchParams],
searchParams,
onSearchParamsChange: setSearchParams,
onUpdate: connectionlogsQuery.goToFirstPage,
});

Expand Down
Loading