Skip to content

feat: Add selected template link at the template select field #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 31, 2022
Merged

feat: Add selected template link at the template select field #1918

merged 6 commits into from
May 31, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

  • Add the selected template link at the template select field
  • Made a minor refactoring in the forms to make them look more consistent

Closes #1864

Before:
Screen Shot 2022-05-31 at 11 57 47

After:
Screen Shot 2022-05-31 at 11 56 57

@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner May 31, 2022 14:58
@BrunoQuaresma BrunoQuaresma self-assigned this May 31, 2022
@BrunoQuaresma
Copy link
Collaborator Author

It is also related to #1638

Kira-Pilot
Kira-Pilot approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! What do you think about left aligning that 'Read more' helper text against the left border of the input?

@BrunoQuaresma
Copy link
Collaborator Author

@Kira-Pilot I've been thinking about that and I think it is best and we probably want this for all the text helpers. @vapurrmaid @presleyp @ashmeer7 what do you think?

@BrunoQuaresma
Copy link
Collaborator Author

I was wondering why the text helper for the schedule form was aligned to the left without any extra style, and I found we are using the input as "underline" instead of "contained" in the schedule. @vapurrmaid are you ok if I change the Schedule form to use the default(contained) type for inputs?

@greyscaled
Copy link
Contributor

greyscaled commented May 31, 2022 •
edited
Loading

I was wondering why the text helper for the schedule form was aligned to the left without any extra style, and I found we are using the input as "underline" instead of "contained" in the schedule. @vapurrmaid are you ok if I change the Schedule form to use the default(contained) type for inputs?

sure - this SGTM 🎉 !

@greyscaled
Copy link
Contributor

@Kira-Pilot I've been thinking about that and I think it is best and we probably want this for all the text helpers. @vapurrmaid @presleyp @ashmeer7 what do you think?

Great suggestions 🙌🏻 !

@BrunoQuaresma
Copy link
Collaborator Author

They look good!
Screen Shot 2022-05-31 at 15 18 09

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) May 31, 2022 18:25
@BrunoQuaresma BrunoQuaresma merged commit 65c17a0 into main May 31, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/add-more-info-on-create-workspace-form branch May 31, 2022 18:28
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@BrunoQuaresma @kylecarbs
feat: Add selected template link at the template select field (#1918)
cd2229d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display a template link in the Create Workspace form when the user selects the template.
3 participants
@BrunoQuaresma @greyscaled @Kira-Pilot