I didn't find any Jest tests that failed, do we have any snapshot tests for our React components, or any other sort of screenshots that need an update? The Storybook for UserDropdown does not contain the menu items, may be we should fix that?

I didn't find any Jest tests that failed, do we have any snapshot tests for our React components, or any other sort of screenshots that need an update? The Storybook for UserDropdown does not contain the menu items, may be we should fix that?

That's a good callout. I think adding a story with the UserDropdown open would be helpful. A quick way to do this might be to add a prop to open the dropdown, and then set that prop to true in the story. Haven't dug into this very much so lmk if you want to pair!

@AbhineetJain Thanks this is great - as are your callouts. Would you be down to add a story for this one?

I think it could be the case that our snapshot is always picking up the menu when it's in a closed state.

I didn't find any Jest tests that failed, do we have any snapshot tests for our React components, or any other sort of screenshots that need an update? The Storybook for UserDropdown does not contain the menu items, may be we should fix that?

We don't snapshot test with jest - we use Storybook & Chromatic.

We'd see if any snapshots changed or were broken in CI.

Edit:

Screenshot

@Kira-Pilot @vapurrmaid Thanks for the suggestions. Let me add a new story with the dropdown open.