Skip to content

feat: claim prebuilds based on workspace parameters instead of preset id #19279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 20, 2025
Merged

feat: claim prebuilds based on workspace parameters instead of preset id #19279

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0890d84
test: provide an ergonomic way to access the test database for debugging
SasSwart Aug 15, 2025
a94d03e
comment
SasSwart Aug 15, 2025
96f0b37
use a functional option instead
SasSwart Aug 15, 2025
a9e0f1d
Initial, inefficient attempt at preset parameter matching
SasSwart Aug 7, 2025
292a1a9
Implement preset auto match
SasSwart Aug 15, 2025
b40e78f
go vet
SasSwart Aug 15, 2025
6fe0dd0
make fmt
SasSwart Aug 15, 2025
735e937
Fix tests
SasSwart Aug 15, 2025
151a039
remove dead code
SasSwart Aug 15, 2025
2c5647f
Document preset detection behaviour
SasSwart Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove dead code
  • Loading branch information
@SasSwart
SasSwart committed Aug 15, 2025
commit 151a03925520e9f6e18eb7ac503cb726365a02e7
22 changes: 0 additions & 22 deletions coderd/database/dbauthz/dbauthz_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4975,28 +4975,6 @@ func (s *MethodTestSuite) TestPrebuilds() {
ParameterValues: []string{"test"},
}).Asserts(tv.RBACObject(t1), policy.ActionRead).Returns(uuid.Nil)
}))
// s.Run("FindMatchingPresetID", s.Subtest(func(db database.Store, check *expects) {
// org := dbgen.Organization(s.T(), db, database.Organization{})
// user := dbgen.User(s.T(), db, database.User{})
// templateVersion := dbgen.TemplateVersion(s.T(), db, database.TemplateVersion{
// OrganizationID: org.ID,
// CreatedBy: user.ID,
// })
// template := dbgen.Template(s.T(), db, database.Template{
// OrganizationID: org.ID,
// CreatedBy: user.ID,
// ActiveVersionID: templateVersion.ID,
// })
// db.UpdateTemplateActiveVersionByID(context.Background(), database.UpdateTemplateActiveVersionByIDParams{
// ID: template.ID,
// ActiveVersionID: templateVersion.ID,
// })
// check.Args(database.FindMatchingPresetIDParams{
// TemplateVersionID: templateVersion.ID,
// ParameterNames: []string{"test"},
// ParameterValues: []string{"test"},
// }).Asserts(templateVersion.RBACObject(template), policy.ActionRead)
// }))
s.Run("GetPrebuildMetrics", s.Subtest(func(_ database.Store, check *expects) {
check.Args().
Asserts(rbac.ResourceWorkspace.All(), policy.ActionRead)
Expand Down
Loading