Skip to content

refactor: create tasks in coderd instead of frontend #19280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 12, 2025
Merged

refactor: create tasks in coderd instead of frontend #19280

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
30b4008
refactor: lift task creation to coderd
DanielleMaywood Aug 11, 2025
16eee74
fix: add parallel to test
DanielleMaywood Aug 11, 2025
0cd6fde
fix: add `format:"uuid"` to `uuid.UUID` fields
DanielleMaywood Aug 11, 2025
d9e7e08
fix: return error if template does not have an "AI Prompt" parameter
DanielleMaywood Aug 11, 2025
e4695ff
fix: add parallel to test
DanielleMaywood Aug 11, 2025
0ad6ce3
fix: broken test
DanielleMaywood Aug 11, 2025
66a4fd7
test: fail on an invalid template
DanielleMaywood Aug 11, 2025
6e14061
refactor: remove magic strings
DanielleMaywood Aug 11, 2025
ae212d0
fix: add parallel to test (yet again)
DanielleMaywood Aug 11, 2025
5a671e8
fix: add api rate limiter to ai tasks create
DanielleMaywood Aug 11, 2025
08cab33
refactor: names used
DanielleMaywood Aug 11, 2025
27b5823
chore: `aiTasksCreate` -> `tasksCreate`
DanielleMaywood Aug 12, 2025
9b5a99c
chore: finish making that change
DanielleMaywood Aug 12, 2025
e1d9fd4
chore: sprintf
DanielleMaywood Aug 12, 2025
dc041de
chore: oops
DanielleMaywood Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: aiTasksCreate -> tasksCreate
  • Loading branch information
@DanielleMaywood
DanielleMaywood committed Aug 12, 2025
commit 27b58230e070d17de99855857514940d1671cc9d
22 changes: 5 additions & 17 deletions coderd/aitasks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,31 +70,19 @@ func (api *API) aiTasksPrompts(rw http.ResponseWriter, r *http.Request) {

// This endpoint is experimental and not guaranteed to be stable, so we're not
// generating public-facing documentation for it.
func (api *API) aiTasksCreate(rw http.ResponseWriter, r *http.Request) {
func (api *API) tasksCreate(rw http.ResponseWriter, r *http.Request) {
var (
ctx = r.Context()
apiKey = httpmw.APIKey(r)
auditor = api.Auditor.Load()
member = httpmw.OrganizationMemberParam(r)
)

var req codersdk.CreateAITasksRequest
if !httpapi.Read(ctx, rw, r, &req) {
return
}

user, err := api.Database.GetUserByID(ctx, apiKey.UserID)
if httpapi.Is404Error(err) {
httpapi.ResourceNotFound(rw)
return
}
if err != nil {
httpapi.Write(ctx, rw, http.StatusInternalServerError, codersdk.Response{
Message: "Internal error fetching user.",
Detail: err.Error(),
})
return
}

hasAITask, err := api.Database.GetTemplateVersionHasAITask(ctx, req.TemplateVersionID)
if err != nil {
if errors.Is(err, sql.ErrNoRows) || rbac.IsUnauthorizedError(err) {
Expand Down Expand Up @@ -125,9 +113,9 @@ func (api *API) aiTasksCreate(rw http.ResponseWriter, r *http.Request) {
}

owner := workspaceOwner{
ID: user.ID,
Username: user.Username,
AvatarURL: user.AvatarURL,
ID: member.UserID,
Username: member.Username,
AvatarURL: member.AvatarURL,
}

aReq, commitAudit := audit.InitRequest[database.WorkspaceTable](rw, &audit.RequestParams{
Expand Down
5 changes: 4 additions & 1 deletion coderd/coderd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -994,8 +994,11 @@ func New(options *Options) *API {
r.Use(apiKeyMiddleware)
r.Route("/aitasks", func(r chi.Router) {
r.Get("/prompts", api.aiTasksPrompts)
})
r.Route("/tasks", func(r chi.Router) {
r.Use(apiRateLimiter)

r.With(apiRateLimiter).Post("/", api.aiTasksCreate)
r.Post("/{user}", api.tasksCreate)
})
r.Route("/mcp", func(r chi.Router) {
r.Use(
Expand Down
Loading