fix: upload the slim binaries from the build directory to the GCS bucket #19281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/release.yaml
Outdated
Comment on lines
645
to
656
| slim_binaries=( | ||
| "coder-slim_${version}_darwin_amd64" | ||
| "coder-slim_${version}_darwin_arm64" | ||
| "coder-slim_${version}_linux_amd64" | ||
| "coder-slim_${version}_linux_arm64" | ||
| "coder-slim_${version}_linux_armv7" | ||
| "coder-slim_${version}_windows_amd64.exe" | ||
| "coder-slim_${version}_windows_arm64.exe" | ||
| ) | ||
|
|
||
| # Target array of CLI binary names | ||
| cli_binaries=( |
There was a problem hiding this comment.
Maybe use an associative array? It's essentially a map. Avoids using two arrays
declare -A binaries
binaries["coder-darwin-amd64"] = "build/coder_slim_${version}-darwin_amd64"
There was a problem hiding this comment.
There was a problem hiding this comment.
Thought about it but I think having two arrays makes it actually more readable.
There was a problem hiding this comment.
Ok, change my mind - it's actually nice
deansheather
approved these changes
Aug 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes were made: