feat(cli): add enterprise external-workspaces CLI command #19287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1d9ad42 to
2b42673
Compare
b641ffe to
07a9c42
Compare
039892b to
e1fd6e8
Compare
60cccc2 to
0cf5381
Compare
e1fd6e8 to
e7e9376
Compare
deansheather
approved these changes
Aug 13, 2025
| @@ -29,7 +29,12 @@ const PresetNone = "none" | |||
|
|
|||
| var ErrNoPresetFound = xerrors.New("no preset found") | |||
|
|
|||
| func (r *RootCmd) create() *serpent.Command { | |||
| type CreateOptions struct { | |||
There was a problem hiding this comment.
Maybe you should put a comment here explaining what these are for. E.g. "CreateOptions provides middleware for the workspace creation command so it can be extended for other create commands."
enterprise/cli/externalworkspaces.go
Outdated
| } | ||
|
|
||
| var hasExternalAgent bool | ||
| for _, resource := range resources { |
There was a problem hiding this comment.
Why not just use the flag? Is it not returned by the API?
enterprise/cli/externalworkspaces.go
Outdated
Comment on lines
19
to
20
| WorkspaceName string `json:"-"` | ||
| AgentName string `json:"-"` |
There was a problem hiding this comment.
In JSON output mode I imagine these fields could be useful
d36771a to
cec9a8d
Compare
4e94ed6 to
5a0bf15
Compare
ac11687 to
515fd53
Compare
5a0bf15 to
ed93d09
Compare
515fd53 to
ce5c3e0
Compare
ce5c3e0 to
d5f8141
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for external workspace management, allowing users to register and manage workspaces that are provisioned and managed outside of the Coder.