Skip to content

chore(coderd/database/dbauthz): migrate more tests to mocked db #19300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: hugodutka/dbauthz-mock-1
Choose a base branch
from
Open

chore(coderd/database/dbauthz): migrate more tests to mocked db #19300

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b7ff778
test(dbauthz): migrate four groups to mocked db (License, Organizatio…
blink-so[bot] Aug 9, 2025
d3911a5
test(dbauthz): migrate TestDBCrypt to mocked db
hugodutka Aug 9, 2025
4818c28
test(dbauthz): migrate TestCryptoKeys to mocked db
hugodutka Aug 9, 2025
52c9044
test(dbauthz): migrate TestUserSecrets to mocked db
hugodutka Aug 9, 2025
b615cb1
chore: format
hugodutka Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(dbauthz): migrate TestDBCrypt to mocked db 
- Convert DBCrypt subtests to s.Mocked with gomock expectations
- Remove reliance on real DB for setup
- Keeps consistent style with prior groups
  • Loading branch information
@hugodutka
hugodutka committed Aug 11, 2025
commit d3911a574517ac1ab4f7126ee31ccc6049bc4b06
37 changes: 18 additions & 19 deletions coderd/database/dbauthz/dbauthz_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3783,25 +3783,24 @@ func (s *MethodTestSuite) TestTailnetFunctions() {
}

func (s *MethodTestSuite) TestDBCrypt() {
s.Run("GetDBCryptKeys", s.Subtest(func(db database.Store, check *expects) {
check.Args().
Asserts(rbac.ResourceSystem, policy.ActionRead).
Returns([]database.DBCryptKey{})
}))
s.Run("InsertDBCryptKey", s.Subtest(func(db database.Store, check *expects) {
check.Args(database.InsertDBCryptKeyParams{}).
Asserts(rbac.ResourceSystem, policy.ActionCreate).
Returns()
}))
s.Run("RevokeDBCryptKey", s.Subtest(func(db database.Store, check *expects) {
err := db.InsertDBCryptKey(context.Background(), database.InsertDBCryptKeyParams{
ActiveKeyDigest: "revoke me",
})
s.NoError(err)
check.Args("revoke me").
Asserts(rbac.ResourceSystem, policy.ActionUpdate).
Returns()
}))
s.Run("GetDBCryptKeys", s.Mocked(func(dbm *dbmock.MockStore, _ *gofakeit.Faker, check *expects) {
dbm.EXPECT().GetDBCryptKeys(gomock.Any()).Return([]database.DBCryptKey{}, nil).AnyTimes()
check.Args().
Asserts(rbac.ResourceSystem, policy.ActionRead).
Returns([]database.DBCryptKey{})
}))
s.Run("InsertDBCryptKey", s.Mocked(func(dbm *dbmock.MockStore, _ *gofakeit.Faker, check *expects) {
dbm.EXPECT().InsertDBCryptKey(gomock.Any(), database.InsertDBCryptKeyParams{}).Return(nil).AnyTimes()
check.Args(database.InsertDBCryptKeyParams{}).
Asserts(rbac.ResourceSystem, policy.ActionCreate).
Returns()
}))
s.Run("RevokeDBCryptKey", s.Mocked(func(dbm *dbmock.MockStore, _ *gofakeit.Faker, check *expects) {
dbm.EXPECT().RevokeDBCryptKey(gomock.Any(), "revoke me").Return(nil).AnyTimes()
check.Args("revoke me").
Asserts(rbac.ResourceSystem, policy.ActionUpdate).
Returns()
}))
}

func (s *MethodTestSuite) TestCryptoKeys() {
Expand Down