Skip to content

fix: correct markup for Abbr component #19317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: correct markup for Abbr component #19317

wants to merge 1 commit into from

Conversation

Parkreiner
Copy link
Member

@Parkreiner Parkreiner commented Aug 12, 2025

Fixes some accidental styling issues introduced in #19242

Almost done. Just need to fix up some stories.

Changes made

  • Updated styles
  • Added support for className prop so that we can override the styles as needed
  • Removed the aria-label in favor of injecting the main text directly

Notes

  • This feels like a case where the changes in the previous PR were actually correct overall, but something with our MUI+Tailwind setup created conflicting styles, and we accidentally introduced an underline style that shouldn't be there
  • Removed the Aria label because I've realized in the past year that Aria is really easy to misuse, and it's best just to do things with the base HTML features as much as possible. There's a risk that the old code had compliance issues with certain types of screen readers (even though it worked fine when I did manual testing back in 2023). These changes hopefully remove those risks completely

@Parkreiner Parkreiner self-assigned this Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant