Skip to content

chore: update storybook config to use TS #19343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 14, 2025
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

CommonJS on main configuration is going to be deprecated so I updated them to use TS.

Using CommonJS in your main configuration file is deprecated with Vite.

@BrunoQuaresma BrunoQuaresma self-assigned this Aug 13, 2025
@BrunoQuaresma BrunoQuaresma requested a review from aslilac as a code owner August 13, 2025 20:03
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes pls!!

@BrunoQuaresma
Copy link
Collaborator Author

I'm having a hard time to figure out why the storybook build on chromatic looks way different than the one locally. I started a chat with the Chromatic team to see if they can help us.

@aslilac aslilac force-pushed the bq/storybook-move-config-to-ts branch from e23fed0 to cd7d253 Compare August 14, 2025 22:56
@aslilac aslilac merged commit 1d1a16e into main Aug 14, 2025
32 checks passed
@aslilac aslilac deleted the bq/storybook-move-config-to-ts branch August 14, 2025 23:05
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants