Skip to content

chore: set editorconfig to use spaces instead of tabs for sql files #19344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+8 −0
Open

chore: set editorconfig to use spaces instead of tabs for sql files #19344

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ea4f9cf
chore: editorconfig to use spaces over tabs for sql
Emyrk Aug 13, 2025
caa0199
convert some more sql files
Emyrk Aug 13, 2025
3d1b01f
switch to tabs
Emyrk Aug 14, 2025
975ca2a
revert gen
Emyrk Aug 14, 2025
338ae60
newline at end
Emyrk Aug 14, 2025
18e58ab
include migrations in sql tabs
Emyrk Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,11 @@ indent_size = 2
[coderd/database/dump.sql]
indent_style = space
indent_size = 4

[coderd/database/queries/*.sql]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[coderd/database/queries/*.sql]
[*.sql]

it'd be nice if everything was included. we could reformat migrations, or at least format them going forward. with all of the views we have that need to be recreated when you edit an underlying table stuff ends up getting copied and pasted around a lot.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one I was avoiding was dump.sql which is generated by pg_dump and uses spaces. I don't want an editor config formatter to cause diffs in an autogenerated file.

I can extend this to migrations

indent_style = tab
indent_size = 4

[coderd/database/migrations/*.sql]
indent_style = tab
indent_size = 4