chore: remove some usage of useClassName
#19346
Merged
+132
−226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettkolodny
requested changes
Aug 14, 2025
| switch (variant) { | ||
| case "error": | ||
| return theme.palette.error.main; | ||
| return "border-highlight-red"; |
There was a problem hiding this comment.
Just double checking, did border-border-destructive not look right?
There was a problem hiding this comment.
I think they're basically the same color
| )} | ||
| </IconButton> | ||
| </Tooltip> | ||
| </div> | ||
| <div css={{ fontWeight: 500, marginTop: 16 }}> | ||
| <div className="text-medium mt-4"> |
There was a problem hiding this comment.
This should be font-medium as well as the ones below
brettkolodny
approved these changes
Aug 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hook is major tech debt. It's pretty hacky way to get emotion to give you a stable class name, which was more necessary when it was our primary method of styling. Now that we're migrating to Tailwind we should get rid of all usage of this hook and eventually remove it.