Skip to content

refactor: convert workspacesdk.AgentConn to an interface #19392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 20, 2025
Merged

refactor: convert workspacesdk.AgentConn to an interface #19392

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1cc4903
refactor: convert workspacesdk.AgentConn to an interface
DanielleMaywood Aug 18, 2025
ea4de03
chore: appease linter
DanielleMaywood Aug 18, 2025
fa0b97e
chore: comments
DanielleMaywood Aug 18, 2025
123760a
chore: add validation that channel works first
DanielleMaywood Aug 18, 2025
4c9a9e6
Merge branch 'main' into danielle/flake/payload-too-large
DanielleMaywood Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: comments
  • Loading branch information
@DanielleMaywood
DanielleMaywood committed Aug 18, 2025
commit fa0b97ea0c00560edd12f78fc6926e76ff093436
6 changes: 5 additions & 1 deletion coderd/workspaceagents_internal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ func TestWatchAgentContainers(t *testing.T) {
t.Run("WebSocketClosesProperly", func(t *testing.T) {
t.Parallel()

// This test ensures that the agent containers `/watch` websocket can gracefully
// handle the underlying websocket unexpectedly closing. This test was created in
// response to this issue: https://github.com/coder/coder/issues/19372

var (
ctx = testutil.Context(t, testutil.WaitShort)
logger = slogtest.Make(t, &slogtest.Options{IgnoreErrors: true}).Leveled(slog.LevelDebug).Named("coderd")
Expand Down Expand Up @@ -130,7 +134,7 @@ func TestWatchAgentContainers(t *testing.T) {
// And: Allow `db2dsk.WorkspaceAgent` to complete.
mCoordinator.EXPECT().Node(gomock.Any()).Return(nil)

// And: Allow `WatchContainers` to be called.
// And: Allow `WatchContainers` to be called, returing our `containersCh` channel.
mAgentConn.EXPECT().WatchContainers(gomock.Any(), gomock.Any()).
Return(containersCh, io.NopCloser(&bytes.Buffer{}), nil)

Expand Down
Loading