fix: resolve TestAPI/Error/DuringInjection flake
#19407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielleMaywood
commented
Aug 19, 2025
Comment on lines
-2099
to
-2100
| coderBin, err := os.Executable() | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
It looks like this might sometimes be a symlink which we aren't resolving which causes a problem in the tests on nightly gauntlet. Instead of resolving this symlink, I've just removed this and replaced the mock expectation with gomock.Any() as we don't really care about this for this test.
DanielleMaywood
commented
Aug 19, 2025
Comment on lines
+2157
to
+2158
| err = api.RefreshContainers(ctx) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
drive by fix: whilst trying to recreate this flake, i got this to fail because the clock would skip a turn for some reason, so instead we just invoke RefreshContainers directly.
johnstcn
approved these changes
Aug 19, 2025
mafredri
approved these changes
Aug 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves coder/internal#905