Skip to content

fix: fix more TestWorkspaceAutobuild flakes #19417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2025
Merged

fix: fix more TestWorkspaceAutobuild flakes #19417

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
229866f
this line should pass tickTime2 not tickTime
cstyan Aug 18, 2025
7a0ea8f
two more tickTime2 fixes
cstyan Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions enterprise/coderd/workspaces_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1122,7 +1122,7 @@ func TestWorkspaceAutobuild(t *testing.T) {

// Simulate the workspace being dormant beyond the threshold.
tickTime2 := ws.DormantAt.Add(2 * transitionTTL)
coderdtest.UpdateProvisionerLastSeenAt(t, db, p.ID, tickTime)
coderdtest.UpdateProvisionerLastSeenAt(t, db, p.ID, tickTime2)
ticker <- tickTime2
stats = <-statCh
require.Len(t, stats.Transitions, 1)
Expand Down Expand Up @@ -1277,7 +1277,7 @@ func TestWorkspaceAutobuild(t *testing.T) {

// We should see the workspace get stopped now.
tickTime2 := ws.LastUsedAt.Add(inactiveTTL * 2)
coderdtest.UpdateProvisionerLastSeenAt(t, db, p.ID, tickTime)
coderdtest.UpdateProvisionerLastSeenAt(t, db, p.ID, tickTime2)
tickCh <- tickTime2
stats = <-statsCh
require.Len(t, stats.Errors, 0)
Expand Down Expand Up @@ -1481,7 +1481,7 @@ func TestWorkspaceAutobuild(t *testing.T) {

// Force an autostart transition again.
tickTime2 := sched.Next(firstBuild.CreatedAt)
coderdtest.UpdateProvisionerLastSeenAt(t, db, p.ID, tickTime)
coderdtest.UpdateProvisionerLastSeenAt(t, db, p.ID, tickTime2)
tickCh <- tickTime2
stats = <-statsCh
require.Len(t, stats.Errors, 0)
Expand Down
Loading