Skip to content

fix: fix workspaces pagination #19448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 21, 2025
Merged

fix: fix workspaces pagination #19448

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6b10145
fix: fix workspaces pagination
BrunoQuaresma Aug 20, 2025
c63fc7d
improve tests
BrunoQuaresma Aug 20, 2025
7c4ce4d
Make tests more reliable
BrunoQuaresma Aug 20, 2025
ed86e7f
Fix lint
BrunoQuaresma Aug 20, 2025
275116b
Improve tests
BrunoQuaresma Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make tests more reliable
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Aug 20, 2025
commit 7c4ce4da7b573f70d159e760708adc57c5f7cfee
23 changes: 14 additions & 9 deletions site/src/pages/WorkspacesPage/WorkspacesPage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,15 +321,20 @@ describe("WorkspacesPage", () => {

const getWorkspacesSpy = jest.spyOn(API, "getWorkspaces");

getWorkspacesSpy
.mockResolvedValueOnce({
workspaces: workspacesPage1,
count: totalWorkspaces,
})
.mockResolvedValueOnce({
workspaces: workspacesPage2,
count: totalWorkspaces,
});
getWorkspacesSpy.mockImplementation(({ offset }) => {
if (offset === 0) {
return Promise.resolve({
workspaces: workspacesPage1,
count: totalWorkspaces,
});
} else if (offset === 25) {
return Promise.resolve({
workspaces: workspacesPage2,
count: totalWorkspaces,
});
}
return Promise.reject(new Error("Unexpected offset"));
});

const user = userEvent.setup();
renderWithAuth(<WorkspacesPage />);
Expand Down
Loading