Skip to content

ci: add check-build job to require make build to pass on prs #19460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 21, 2025
Merged

ci: add check-build job to require make build to pass on prs #19460

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0224f6e
ci: send slack notif on main build failures
ethanndickson Aug 21, 2025
99bde5a
new check-build job
ethanndickson Aug 21, 2025
d201304
go change to trigger workflow
ethanndickson Aug 21, 2025
225cc19
undo
ethanndickson Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
new check-build job
  • Loading branch information
@ethanndickson
ethanndickson committed Aug 21, 2025
commit 99bde5ab608d3a542566c776a55c0d76b66225dc
41 changes: 40 additions & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,7 @@ jobs:
- test-e2e
- offlinedocs
- sqlc-vet
- check-build
# Allow this job to run even if the needed jobs fail, are skipped or
# cancelled.
if: always()
Expand All @@ -936,6 +937,7 @@ jobs:
echo "- test-js: ${{ needs.test-js.result }}"
echo "- test-e2e: ${{ needs.test-e2e.result }}"
echo "- offlinedocs: ${{ needs.offlinedocs.result }}"
echo "- check-build: ${{ needs.check-build.result }}"
echo

# We allow skipped jobs to pass, but not failed or cancelled jobs.
Expand Down Expand Up @@ -1026,6 +1028,44 @@ jobs:
if: ${{ github.repository_owner == 'coder' && github.ref == 'refs/heads/main' }}
run: rm -f /tmp/{apple_cert.p12,apple_cert_password.txt,apple_apikey.p8}

check-build:
# This job runs make build to verify compilation on PRs
needs: changes
if: needs.changes.outputs.go == 'true' && github.ref != 'refs/heads/main'
runs-on: ${{ github.repository_owner == 'coder' && 'depot-ubuntu-22.04-8' || 'ubuntu-latest' }}
steps:
- name: Harden Runner
uses: step-security/harden-runner@ec9f2d5744a09debf3a187a3f4f675c53b671911 # v2.13.0
with:
egress-policy: audit

- name: Checkout
uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4.3.0
with:
fetch-depth: 0

- name: Setup Node
uses: ./.github/actions/setup-node

- name: Setup Go
uses: ./.github/actions/setup-go

- name: Install go-winres
run: go install github.com/tc-hib/go-winres@d743268d7ea168077ddd443c4240562d4f5e8c3e # v0.3.3

- name: Install nfpm
run: go install github.com/goreleaser/nfpm/v2/cmd/nfpm@v2.35.1

- name: Install zstd
run: sudo apt-get install -y zstd

- name: Build
run: |
set -euxo pipefail
go mod download
make gen/mark-fresh
make build

build:
# This builds and publishes ghcr.io/coder/coder-preview:main for each commit
# to main branch.
Expand Down Expand Up @@ -1541,7 +1581,6 @@ jobs:

notify-slack-on-failure:
needs:
- build
- required
runs-on: ubuntu-latest
if: failure() && github.ref == 'refs/heads/main'
Expand Down
Loading