Skip to content

feat(coderd): add tasks list and get endpoints #19468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 22, 2025
+523 −1
Merged

feat(coderd): add tasks list and get endpoints #19468

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bd14ddd
feat(coderd): add tasks list and get endpoints
mafredri Aug 21, 2025
2fb2d4b
make gen
mafredri Aug 21, 2025
f301ba0
swagger
mafredri Aug 22, 2025
59c9c7e
improve task status
mafredri Aug 22, 2025
66fbc02
refactor task status/state
mafredri Aug 22, 2025
bb8ad89
initial prompt
mafredri Aug 22, 2025
c14753a
pr feedback on test
mafredri Aug 22, 2025
e7c22dd
enforce ai task workspaces
mafredri Aug 22, 2025
0c439d8
little docs
mafredri Aug 22, 2025
fdad499
fix
mafredri Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
enforce ai task workspaces
  • Loading branch information
@mafredri
mafredri committed Aug 22, 2025
commit e7c22ddd90a0d30eaaf6feb130490ae4ba4b9857
10 changes: 9 additions & 1 deletion coderd/aitasks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,16 @@ func (api *API) tasksCreate(rw http.ResponseWriter, r *http.Request) {
}

// tasksFromWorkspaces converts a slice of API workspaces into tasks, fetching
// prompts and mapping status/state.
// prompts and mapping status/state. This method enforces that only AI task
// workspaces are given.
func (api *API) tasksFromWorkspaces(ctx context.Context, apiWorkspaces []codersdk.Workspace) ([]codersdk.Task, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we fine with this not validating that the passed in workspaces are tasks? I understand that where it is currently called from we only pass tasks in, I'm just curious.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably no harm to filter out workspaces that are not "tasks", wdyt?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be an error if passed to this function. Handling exists in both list and get endpoints currently, before calling this, but I can add a guard here as well or try to consolidate some more of the code into this method.

// Enforce that only AI task workspaces are given.
for _, ws := range apiWorkspaces {
if ws.LatestBuild.HasAITask == nil || !*ws.LatestBuild.HasAITask {
return nil, fmt.Errorf("workspace %s is not an AI task workspace", ws.ID)
}
}

// Fetch prompts for each workspace build and map by build ID.
buildIDs := make([]uuid.UUID, 0, len(apiWorkspaces))
for _, ws := range apiWorkspaces {
Expand Down
Loading