Skip to content

feat: Handle pagination cases where after_id does not exist #1947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 2, 2022
Merged

feat: Handle pagination cases where after_id does not exist #1947

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
132784e
feat: Handle pagination cases where after_id does not exist
Emyrk Jun 1, 2022
0e4a3c0
import ordering
Emyrk Jun 1, 2022
303feb1
feat: Use InTx to ensure db calls are consistent
Emyrk Jun 1, 2022
cffcd71
fix: Use correct db inside InTx
Emyrk Jun 1, 2022
be23937
Ruleguard is acting strange... will move to another PR
Emyrk Jun 1, 2022
1c6f546
Merge remote-tracking branch 'origin/main' into stevenmasley/paginati…
Emyrk Jun 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ruleguard is acting strange... will move to another PR
  • Loading branch information
@Emyrk
Emyrk committed Jun 1, 2022
commit be23937424ae69d30ba9fb5160901c7a16870ceb
49 changes: 0 additions & 49 deletions scripts/rules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,52 +69,3 @@ func doNotCallTFailNowInsideGoroutine(m dsl.Matcher) {
Where(m["t"].Type.Implements("testing.TB") && m["fail"].Text.Matches("^(FailNow|Fatal|Fatalf)$")).
Report("Do not call functions that may call t.FailNow in a goroutine, as this can cause data races (see testing.go:834)")
}

// InTx checks to ensure the database used inside the transaction closure is the transaction
// database, and not the original database that creates the tx.
func InTx(m dsl.Matcher) {
m.Import("github.com/coder/coder/coderd/database")

// ':=' and '=' are different matches. Really...
m.Match(`
$x.InTx(func($y database.Store) error {
$*_
$*_ := $x.$f($*_)
$*_
})
`, `
$x.InTx(func($y database.Store) error {
$*_
$*_ = $x.$f($*_)
$*_
})
`).Where(m["x"].Text != m["y"].Text && m["x"].Type.Implements("database.Store")).
At(m["f"]).
Report("Do not use the database directly within the InTx closure. Use '$y' instead of '$x'.")

// When using a tx closure, ensure that if you pass the db to another
// function inside the closure, it is the tx.
// This will miss more complex cases such as passing the db as apart
// of another struct.
m.Match(
`
$x.InTx(func($y database.Store) error {
$*_
$*_ := $f($*_, $x, $*_)
$*_
})
`, `
$x.InTx(func($y database.Store) error {
$*_
$*_ = $f($*_, $x, $*_)
$*_
})
`, `
$x.InTx(func($y database.Store) error {
$*_
$f($*_, $x, $*_)
$*_
})
`).Where(m["x"].Text != m["y"].Text && m["x"].Type.Implements("database.Store")).
At(m["f"]).Report("Pass the tx database into the '$f' function inside the closure. Use '$y' over $x'")
}